Explicitly set VideoTexture#colorSpace to SRGBColorSpace
#31534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycw
changed the title
colorSpace to SRGBColorSpace for the new apporachVideoTexture#colorSpace to SRGBColorSpace
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Jul 31, 2025
Mugen87
approved these changes
Jul 31, 2025
|
Yes, a warning that informs about an invalid color space is surely helpful. |
|
@ycw Are you interested in giving this a try? A possible place for a check is below when the texture is initialized for the first time: three.js/src/renderers/common/Textures.js Lines 320 to 323 in 54ac263 Although @sunag might recommend an alternative place. |
If the idea is to align with both backends it would be a good place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #31416, Discussion: #31533
Due to inherent design constraints in WebGPURenderer,
VideoTexture#colorSpacemust be explicitly set to SRGBColorSpace. Assigning alternative values may result in perceptible color inaccuracies, including luminance shifts and hue distortion. This outcome is a direct consequence of the renderer's internal texture handling mechanisms (i.e. copyExternalImageToTexture with destination.colorSpace:'srgb') and is entirely independent of the color space employed by the browser during video decoding.